search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Remove all references to the ROS 1 bridge from CI. #712

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

Foxy is now End-of-Life, which means we have no active ROS 2 distributions on Focal. In turn, this means that we have no distributions where we can build the ros1_bridge anymore. Remove all of the code dealing with the bridge, which includes:

  1. References to "bridge".
  2. References to "ros1".
  3. References to "mixed overlay".

Note that I'm not entirely sure how to test this. I think if I fire up jobs using this branch, it will probably fail because the templates will be passing variables that the scripts don't understand. I'm open to ideas on what to do for testing here.

@quarkytale FYI. If we merge this, then you'll no longer have any way to run CI for ros1_bridge maintenance. But that problem is coming anyway, because we are also going to drop support for Focal.

nuclearsandwich commented 1 year ago

Note that I'm not entirely sure how to test this. I think if I fire up jobs using this branch, it will probably fail because the templates will be passing variables that the scripts don't understand. I'm open to ideas on what to do for testing here.

A common practice would be to run create_jenkinsjobs.py but scoped only to the test* jobs. Then run test jobs from this branch.

quarkytale commented 1 year ago

Yeah doesn't make sense to add any hacks here to still support ros1_bridge, but since there's community interest in the bridge we can find alternatives (eg, Github actions) to help review incoming dev. No point in blocking this, will start another thread.

clalancette commented 1 year ago

All right, I've deployed this PR to all of the test_* jobs on https://ci.ros2.org. Here are some CI runs (only up to ament_cmake_core, since we are testing the infrastructure not the payload here):

CI:

Packaging: