ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Remove support for rmw_connext_cpp from the scripts. #714

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

The last distribution that supported this (Foxy) is now EOL.

Unfortunately, removing this is more complicated than I would have liked. In particular, the job templates were always setting '--ignore-rmw rmw_connext_dynamic_cpp', and then adding to that list if other RMWs should be ignored. But we no longer have an RMW that we always want to ignore, so we have to pass --ignore-rmw for each of the ones that we want to ignore (because there may not be any). To handle that, we had to change the argparse handling of --ignore-rmw to use the 'extend' action, and then we had to modify the entrypoint.sh to deal with the fact that there might be multiple --ignore-rmw flags, any of which could contain 'rmw_connextdds'.

Note that if we merge in https://github.com/ros2/ci/pull/713 first, this one will need to be rebased.

clalancette commented 1 year ago

All right, with #715 now merged and deployed, I've gone ahead and rebased this. This is now ready for another review.

clalancette commented 1 year ago

All right, I've gone ahead and deployed this change to the test_ jobs only. Here are some test jobs with this in place:

clalancette commented 1 year ago

All right, this is looking good. The normal jobs look OK, and the one where I specifically disabled connext did what I expected and didn't install it. I'm going to go ahead and merge and deploy this one, then move onto the next one.