search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Revamp --ignore-rmw handling. #715

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

The job templates are currently always setting '--ignore-rmw rmw_connext_dynamic_cpp', and then adding to that list if other RMWs should be ignored. But it is not necessarily the case that we will always have an RMW to ignore. Therefore, we switch to passing --ignore-rmw for each of the ones that we want to ignore (because there may not be any). To handle that, change the argparse handling of --ignore-rmw to use the 'extend' action, and then modify the entrypoint.sh to deal with the fact that there might be multiple --ignore-rmw flags, any of which could contain 'connext'.

clalancette commented 1 year ago

Here's some CI runs with this in place (I deployed this just to the test_* jobs).

Regular CI, to test that normal things work:

CI, testing disabling everything but Fast-DDS:

clalancette commented 1 year ago

All right, CI looks good. Going ahead and merging this one, then deploying.