search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Install liblttng-ctl-dev instead of python3-lttng in Rolling #725

Closed christophebedard closed 9 months ago

christophebedard commented 11 months ago

Required for https://github.com/ros2/ros2_tracing/pull/81

We need liblttng-ctl-dev and can drop python3-lttng in Rolling. We still need python3-lttng in Iron, though.

Note that RHEL has liblttng-ctl version 2.12.11, while Ubuntu has 2.13.x.

cottsay commented 11 months ago

The corresponding package on RHEL9 is lttng-tools-devel - please update Dockerfile-RHEL appropriately.

christophebedard commented 11 months ago

I updated Dockerfile-RHEL. We should also probably test a RHEL CI build with the same settings as https://github.com/ros2/ros2_tracing/pull/81#issuecomment-1799142670 (I can't push the branch to this repo, though)

christophebedard commented 11 months ago

@cottsay can you force-push my PR branch to this repo so that I can test the RHEL CI job? Thank you!

mjcarroll commented 11 months ago

@cottsay can you force-push my PR branch to this repo so that I can test the RHEL CI job?

He's OOO, I pushed it.

christophebedard commented 11 months ago

Looks like I can't re-build the Docker image with RHEL/EL 9.2 due to a workaround for #727. Using 9.1 results in the failure described in #727: https://ci.ros2.org/job/ci_linux-rhel/517/. I guess we'll have to wait for this to be fixed.

claraberendsen commented 10 months ago

@christophebedard yes momentarily the 9.2 image is pinned to a stale one with the working dependencies for pyside2

and all other options of building on RHEL 9 are going to result on failures due to the issue linked above. For now sadly until upstream EPEL dependencies breaks are rebuilt for 9.3 and we can move the ci to use the new AlmaLinux 9.3 there is no easy way to change a dependency.

clalancette commented 10 months ago

We're still not quite to the place where we can take this; we first need to revert the 9.2-pinned PR (#728) and ensure everything works. Before we do that, we need to merge in https://github.com/ros-visualization/python_qt_binding/pull/130 . But we are getting closer :).

christophebedard commented 10 months ago

Thanks for the update!

Looks like #728 has been reverted (#732) and https://github.com/ros-visualization/python_qt_binding/pull/130 has been merged. Are we okay to proceed?

claraberendsen commented 10 months ago

@christophebedard Yes, Chris was able to unblock the RHEL situation. You should be unblocked here to run ci again to test your changes.

christophebedard commented 10 months ago

Thanks! Would you (or anyone) mind force-pushing my branch to this repo so that I can (re)run a RHEL job?

claraberendsen commented 10 months ago

Thanks! Would you (or anyone) mind force-pushing my branch to this repo so that I can (re)run a RHEL job?

Latest changes force pushed on christophebedard/install-liblttng-ctl-dev.

christophebedard commented 10 months ago

Looking good now, see new CI (including RHEL) at https://github.com/ros2/ros2_tracing/pull/81#issuecomment-1856673199. This is ready for a final review.

christophebedard commented 9 months ago

This should be ready to be merged.

clalancette commented 9 months ago

@christophebedard Am I correct in thinking that this needs to be merged in concert with https://github.com/ros2/ros2_tracing/pull/81 , so that Rolling nightlies continue to build?

christophebedard commented 9 months ago

Indeed! I can't merge this PR but I can merge the ros2_tracing one right after.

christophebedard commented 9 months ago

@clalancette could you merge this PR? Then right after I can merge https://github.com/ros2/ros2_tracing/pull/81.

clalancette commented 9 months ago

@clalancette could you merge this PR? Then right after I can merge ros2/ros2_tracing#81.

I'm just going to go ahead and merge in both.