search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Switch RHEL 9 to use sip4 instead of PySide2 #730

Closed cottsay closed 10 months ago

cottsay commented 10 months ago

This is a temporary measure to unblock ci.ros2.org builds while we work on a proper solution.

Build Status

cottsay commented 10 months ago

New build combined with ros-visualization/python_qt_binding#129: Build Status

cottsay commented 10 months ago

it needs to be merged in concert

Agreed. I think we'll need to land and release those changes before merging this one to avoid breaking regular RHEL builds here.

cottsay commented 10 months ago

both Iron and Humble

I believe that Humble uses RHEL 8, which doesn't have a new enough version of PyQt5 to have the unsupported flag.

clalancette commented 10 months ago

I believe that Humble uses RHEL 8, which doesn't have a new enough version of PyQt5 to have the unsupported flag.

Correct, Humble is on RHEL-8.

Oh, I see. We've always installed python-sip-devel on RHEL-8; what's new here is installing it on RHEL-9. Thus there should be no change to RHEL-8, and https://github.com/ros-visualization/python_qt_binding/pull/129 isn't needed to be backported to Humble. In that case, I'll kick off one more CI here, which is double-checking that Humble on RHEL-8 is OK with just this patch in place.

clalancette commented 10 months ago

Humble on RHEL-8: Build Status

clalancette commented 10 months ago

All right, going ahead and merging this one and https://github.com/ros-visualization/python_qt_binding/pull/129, then backporting the latter to Iron as well. Humble should be fixed separately; see https://github.com/ros2/ci/pull/731 and https://github.com/ros2/rviz/pull/1105