search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Remove unused --python-interpreter argument. #754

Closed clalancette closed 4 months ago

clalancette commented 5 months ago

We haven't honored this since we removed OSX support, so just get rid of the code.

clalancette commented 5 months ago

As mentioned about, currently we don't use this at all. As of this writing, the way we are finding the Windows Debug interpreter is via some heuristics in python_cmake_module.

In https://github.com/ros2/ros2/pull/1524, we are proposing to remove python_cmake_module, which will of course remove those heuristics. Instead, we'll need to do something different to find the Windows Debug interpreter, which is prototyped in https://github.com/ros2/ci/pull/755 .

clalancette commented 5 months ago

I'm going to deploy this to some test jobs, and run those.

clalancette commented 5 months ago
clalancette commented 4 months ago

After poking at this for a bit, I was mistaken. We do use this, just not in the way I thought.

In particular, we use this during initial setup to pick the correct Python interpreter to use when installing dependencies. That is, this is not related to the python interpreter used during the colcon/cmake build, but is instead the interpreter used when doing setup.

So with that in mind, we actually need to keep this. So I'll close out this PR.