search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Consider restoring --src-mounted argument #756

Closed scpeters closed 4 months ago

scpeters commented 5 months ago

The --src-mounted argument was removed in https://github.com/ros2/ci/pull/752 since it is no longer used in the ROS build farm. It looks like it was used to skip git operations in qemu containers, but since that isn't needed anymore, it was removed.

I have been working with a team at NASA for the VIPER mission that is using ROS 2 (see Jacob's ROS World talk), and we have been using the scripts in this repository to build a custom ROS underlay using a mix of public and private repositories inside a docker container with the --src-mounted argument to avoid configuring authentication to private git servers inside the container when the sources can already be easily cloned on the host and mounted in the container. The VIPER team could fork ros2/ci to restore the --src-mounted argument, but I wanted to create this issue for other folks to chime in if they see value in retaining --src-mounted here. If we do retain it, I expect that we may want to add some kind of test to ensure that it keeps working since it is not used by the official build farm anymore.

scpeters commented 4 months ago

Since no one else has commented here, I take it that no one else is using these scripts in this way. We will work around this issue, and I will close this.