search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Drop cppcheck test exclusion on RHEL #758

Closed cottsay closed 4 months ago

cottsay commented 4 months ago

Previously, the version of cppcheck distributed in RHEL resulted in many (unactionable) linter failures only present on RHEL. Given the limited utility of running the linters on RHEL to begin with, we decided to simply skip the tests.

Changes either to ament_cppcheck or the version of cppcheck distributed in RHEL now appear to allow these tests to run successfully, and the cost of maintaining this special case now outweigh the benefit.

Reverts part of #567

Rolling: Build Status Iron: Build Status Humble: Build Status

clalancette commented 4 months ago

Changes either to ament_cppcheck

It was most likely https://github.com/ament/ament_lint/pull/345 ; cppcheck versions > 2.0 are ridiculously slow, so I ended up disabling them when we switched to Ubuntu 22.04. It looks like Almalinux 8 has cppcheck 2.4 and Almalinux 9 has cppcheck 2.9, so both of them are essentially "skipped" anyway.

Anyway, since we are skipping this in code now, I'm happy to remove this bit from the CI scripts.

cottsay commented 4 months ago

So are we only running cppcheck tests on Humble then? Or I'd suppose Windows runs them?

clalancette commented 4 months ago

So are we only running cppcheck tests on Humble then?

No, even on Humble it is disabled. I think we are only running them on Windows. In all honesty, we can probably drop ament_cppcheck from the default set of linters, but that is a slightly different discussion.