search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Set noble as default ubuntu distribution. #760

Closed marcoag closed 3 months ago

marcoag commented 4 months ago

Adding noble as default ubuntu distribution.

This shouldn't affect iron or humble as they seem to override this value:

https://github.com/ros2/ci/blob/272db1881d96e45b9476da316ca667ef59067af9/create_jenkins_job.py#L462-L463

https://github.com/ros2/ci/blob/272db1881d96e45b9476da316ca667ef59067af9/create_jenkins_job.py#L476-L477

clalancette commented 4 months ago

As it stands, the one reason we can't do this is because python3-flake8 is still broken in Noble. @j-rivero is working on getting that solved in Noble proper, and @claraberendsen may be working on a workaround (by pulling the package from noble-proposed) for the short-term.

claraberendsen commented 4 months ago

@clalancette @marcoag This is the branch to run ci with flake8 from noble-proposed instead of noble. However there seems to be a new error there related to python.

clalancette commented 3 months ago

Before we can merge this one in, we need https://github.com/ros2/ci/pull/766 and some of the fixes from https://github.com/ros2/ci/pull/761 as well.

wjwwood commented 3 months ago

lgtm pending https://github.com/ros2/ci/pull/761

clalancette commented 3 months ago

All right, I believe that we have everything we need now. Here is CI on Noble with the current state of the repository:

clalancette commented 3 months ago

Bah, we still need another PR. See https://github.com/ros2/ci/pull/769

clalancette commented 3 months ago

All right, all CI for this was done in https://github.com/ros2/ci/pull/769 . I'm going to approve, merge, and then deploy this change so we start using Noble as the default for CI.

clalancette commented 3 months ago

And this has now been deployed.