search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Install flake8 from proposed #761

Closed clalancette closed 3 months ago

clalancette commented 4 months ago

This is still a draft because things aren't totally working here; will need another update.

claraberendsen commented 4 months ago

@nuclearsandwich I agree on splitting the flake 8 PR, and link it back to this for testing. I think that overall issues are sistematic and getting the solution for noble given the time constraint we have would be easier to achieve if we have a unified testing branch that imports the changes, so we know when we merge all related PRs then noble should work .

claraberendsen commented 4 months ago

The split PR for installing from proposed: https://github.com/ros2/ci/pull/765

clalancette commented 4 months ago

FYI, I'm still using this PR as a way to test out various changes that we need for Noble. At this point I think what is in here actually makes Noble build; I still need to split out the various fixes into PRs. But anyway, here is a Noble build to see where we are:

clalancette commented 4 months ago

Rebased onto the latest, and more fixes for further changes in Noble, here's another try:

clalancette commented 3 months ago

Over the weekend, it looks like the rest of the packages we needed were rebuilt. I still believe that there is at least one more fix we need here for Humble, but that will be done in separate PRs. I'm going to close this one out for now, thanks @claraberendsen !