search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Fix a couple more problems found while testing CI. #773

Closed clalancette closed 5 months ago

clalancette commented 5 months ago
  1. Make sure to install the connext debians on both jammy and noble. This doesn't make a huge difference on the CI jobs (where we'll install Connext via scripts later anyway), but matters for the packaging jobs.
  2. Revamp how we are installing the LTTng-related packages on RHEL. The logic here is complex enough that it warrants splitting it out to a separate block. To wit, on Humble we install nothing (ros2_tracing is not installed by default), on Iron we install the dependencies plus python3-lttng (we are using the Python bindings as provided by the platform), and on Jazzy and newer we install the lttng-tools-devel package so we can build our own Python bindings. This also makes the RHEL logic match the Ubuntu logic.

@nuclearsandwich @marcoag These are the fixes we talked about earlier this morning @cottsay for review of the RHEL-related parts

clalancette commented 5 months ago

CI: Rolling+Noble amd64 CI: Build Status Rolling+RHEL-9 amd64 CI: Build Status Jazzy+Noble amd64 CI: Build Status Jazzy+RHEL-9 amd64 CI: Build Status Iron+Jammy amd64 CI: Build Status Iron+RHEL-9 amd64 CI: Build Status Humble+Jammy amd64 CI: Build Status Humble+RHEL-8 amd64 CI: Build Status

clalancette commented 5 months ago

New CI after changes from review:

CI: Rolling+Noble amd64 CI: Build Status Rolling+RHEL-9 amd64 CI: Build Status Jazzy+Noble amd64 CI: Build Status Jazzy+RHEL-9 amd64 CI: Build Status Iron+Jammy amd64 CI: Build Status Iron+RHEL-9 amd64 CI: Build Status Humble+Jammy amd64 CI: Build Status Humble+RHEL-8 amd64 CI: Build Status

clalancette commented 5 months ago

And here are packaging jobs:

Rolling+Noble amd64: Build Status Rolling+RHEL-9 amd64: Build Status Jazzy+Noble amd64: Build Status Jazzy+RHEL-9 amd64: Build Status Iron+Jammy amd64: Build Status Iron+RHEL-9 amd64: Build Status Humble+Jammy amd64: Build Status Humble+RHEL-8 amd64: Build Status

clalancette commented 5 months ago

All right. The Humble+RHEL-8 combination is currently failing, but it is failing on master as well: Humble+RHEL-8 amd64 CI: Build Status. I'll address it separately.

With that, I'm going to go ahead and merge this one in. Thanks for the reviews, much appreciated.