search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Install fastjsonschema everywhere. #782

Closed clalancette closed 1 month ago

clalancette commented 1 month ago

We are going to need it for an upcoming change to rosidl.

clalancette commented 1 month ago

CI for this is over in https://github.com/ros2/rosidl/pull/809#issuecomment-2160775257

clalancette commented 1 month ago

lgtm, I guess this is covered by rosdep install in the manual instructions?

Yep, exactly. Though you bring up a good point; for Windows installation instructions, we'll need to add it, since we don't use rosdep there. See https://github.com/ros2/ros2_documentation/pull/4533

clalancette commented 1 month ago

And actually, here is a RHEL-8 canary build, because now I suspect this won't actually work there:

clalancette commented 1 month ago

OK, yeah. I'm going to have to do something slightly different here that requires another PR. Upcoming.

clalancette commented 1 month ago

All right, we now need https://github.com/ros-infrastructure/ros2-cookbooks/pull/71 as well, which should fix this for both Windows and RHEL-8.

clalancette commented 1 month ago

And here is RHEL-8 again with these changes:

clalancette commented 1 month ago

Updated with the latest hash from ros2-cookbooks now that https://github.com/ros-infrastructure/ros2-cookbooks/pull/71 was merged. With that, going ahead and merging.