search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Multi Visual Studio version support #786

Open claraberendsen opened 2 months ago

claraberendsen commented 2 months ago

Description

This PR restores the functionality of selecting which Visual Studio version you want the CI to run with. This is a cherry-pick from the last approach of #784, for more debugging and lot's of test commits you can check the related PR.

This is paired to the changes to ros2-cookbooks in https://github.com/ros-infrastructure/ros2-cookbooks/pull/74

Changes

clalancette commented 1 week ago

@claraberendsen @nuclearsandwich I think I finally, finally figured out all of the complicated issues going on with this PR. Please see the long explanation in https://github.com/ros2/ci/commit/a31b09ac7677afa6aed290cb630287e5b297905d for why everything here is where it is. I would very much appreciate a look from the both of you, since I'd like to get this in to unblock @ahcorde .

Since this PR only touches the Windows jobs, I'm only going to run CI for it. But I'm going to run quite a lot of different CI here. Note that all of these jobs will be run using the test_ci_windows job, since that is the one that has the changes for Windows in the job (once this is approved, I'll obviously do a full deploy).