search

ros2 / demos

Apache License 2.0
502 stars 330 forks source link

Typo: It should be self._timer not self._timer_ #603

Closed vinaym815 closed 1 year ago

vinaym815 commented 1 year ago

The timer being created and destroyed are different. https://github.com/ros2/demos/blob/647b702acbce32ecb8184368f0005a59ce0e7098/lifecycle_py/lifecycle_py/talker.py#L75

clalancette commented 1 year ago

Yes, good call. Can you please submit a pull request with that fix? We'll be happy to review it.