search

ros2 / demos

Apache License 2.0
493 stars 329 forks source link

Fix the quality_of_service_demo_py output to look like the C++ one. #626

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

This just makes the output exactly the same as the C++ one, including printing actual numbers for the change rather than objects.

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

@Yadunund I could use a review on this one when you have time.

clalancette commented 1 year ago

There is a small difference between the info logged by the talkers. The cpp version has the data wrapped in single quotes.

Good catch, fixed in 7c02bd6.

Also should we standardize the node names? listener/talker vs qos_listener/qos_talker

Also a good catch, fixed in 7c02bd6.

clalancette commented 1 year ago

New CI: