Open cardboardcode opened 5 months ago
Encountering the following build error during CI:
12:52:26 rosdep2.lookup.ResolutionError: No definition of [ros_workspace] for OS version [jammy] 12:52:26 rosdep key : ros_workspace 12:52:26 OS name : ubuntu 12:52:26 OS version : jammy
Don't think it is an issue with the new lines of code. Seems like an issue on the backend.
Is there anything I can do to rectify this from my side?
What Is This For?
The purpose of this pull request is to introduce a small but helpful change to the
showimage
ROS 2 node under theimage_tools
package.This change includes a few new lines under the file
image_tools/src/showimage.cpp
that defines the starting position for an OpenCV window display atx=0, y=0
desktop pixel position; the top-left corner of a user's desktop.Why?
I have been using
image_tools
for a quite a while now. Here are the following reasons why I believe this small change could help improve the user experience for any developers who used the ROS 2 node in their own project:Other Remarks
In order to better fit the OpenCV window into a user's desktop automatically, I am considering implementing a resize feature within
showimage
ofimage_tools
ROS 2 package (which should not take long actually).However, I fear it may introduce additional dependencies which may complicate testing down the line. To the maintainers, do let me know your thoughts on this. In the meantime, will do my own testing offline and update if it is just a false fear.
Welcoming any constructive feedbacks on this matter and what I can do to contribute to this amazing community. To the maintainers, thank you for the work you have done so far in this repository and will continue to support in whatever way I can, given personal bandwidth. :relaxed: