search

ros2 / demos

Apache License 2.0
491 stars 329 forks source link

Update dummy_sensors readme to echo the correct topic #675

Closed jmackay2 closed 3 months ago

jmackay2 commented 3 months ago

The output topic of dummy_laser is /scan. This just updates the README to inform the user to echo the /scan topic instead of the /laser topic. This was found while testing https://github.com/osrf/ros2_test_cases/issues/1202.

fujitatomoya commented 3 months ago

@marcoag @clalancette can you merge this and backports?

clalancette commented 3 months ago

Can we target rolling then and then backport?

I've retargeted it to rolling now.

clalancette commented 3 months ago

@Mergifyio backport jazzy iron humble

mergify[bot] commented 3 months ago

backport jazzy iron humble

✅ Backports have been created

* [#684 Update dummy_sensors readme to echo the correct topic (backport #675)](https://github.com/ros2/demos/pull/684) has been created for branch `jazzy` * [#685 Update dummy_sensors readme to echo the correct topic (backport #675)](https://github.com/ros2/demos/pull/685) has been created for branch `iron` * [#686 Update dummy_sensors readme to echo the correct topic (backport #675)](https://github.com/ros2/demos/pull/686) has been created for branch `humble` but encountered conflicts