search

ros2 / demos

Apache License 2.0
491 stars 329 forks source link

[dummy_sensors] update topic name to match code behavior #676

Closed mikaelarguedas closed 3 months ago

mikaelarguedas commented 3 months ago

Found when testing https://github.com/osrf/ros2_test_cases/issues/1203 The dummy_laser publisher on /scan and not on /laser

root@d8ff93e471d7:/# ros2 run dummy_sensors dummy_laser
[INFO] [1714865257.258147676] [dummy_laser]: angle inc: 0.004363
[INFO] [1714865257.258194665] [dummy_laser]: scan size: 1081
[INFO] [1714865257.258202679] [dummy_laser]: scan time increment:   0.000000
root@d8ff93e471d7:~/ros2_ws# ros2 topic list
/parameter_events
/rosout
/scan
fujitatomoya commented 3 months ago

@mikaelarguedas thanks! actually we already have open PR for this, see https://github.com/ros2/demos/pull/675. so i will go ahead to close this one.