search

ros2 / demos

Apache License 2.0
491 stars 329 forks source link

Update dummy_sensors readme to echo the correct topic (backport #675) #686

Closed mergify[bot] closed 3 months ago

mergify[bot] commented 3 months ago

The output topic of dummy_laser is /scan. This just updates the README to inform the user to echo the /scan topic instead of the /laser topic. This was found while testing https://github.com/osrf/ros2_test_cases/issues/1202.

This is an automatic backport of pull request #675 done by Mergify.

mergify[bot] commented 3 months ago

Cherry-pick of eec5c12ea95dfaaa230f9f1a8e9cff9b09dde5d5 has failed:

On branch mergify/bp/humble/pr-675
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit eec5c12.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
    deleted by us:   dummy_robot/dummy_sensors/README.md

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

clalancette commented 3 months ago

We didn't backport this README to humble, so closing this.