search

ros2 / demos

Apache License 2.0
491 stars 329 forks source link

[intra_process_demo] executable name in README.md fix-up #690

Closed trushant05 closed 3 months ago

trushant05 commented 3 months ago

Would like to add that the node name needs to be updated to watermark_node (instead of watermarked_node), Line 75 in the README.md. Node name here.

ahcorde commented 3 months ago

Would like to add that the node name needs to be updated to watermark_node (instead of watermarked_node), Line 75 in the README.md. Node name here.

Do you mind to include these changes ?

trushant05 commented 3 months ago

Would like to add that the node name needs to be updated to watermark_node (instead of watermarked_node), Line 75 in the README.md. Node name here.

Do you mind to include these changes ?

My bad, I have included the changes in the commit.

fujitatomoya commented 3 months ago

@Trushant-Adeshara-UM

My bad, I have included the changes in the commit.

i do not see them. probably caching in your local repo?

trushant05 commented 3 months ago

@fujitatomoya quick question, it is the executable name that needs to be changed in the README.md. So, I just modified that line in the file and committed. Is there something else which I am missing?

fujitatomoya commented 3 months ago

@ahcorde i will leave this to you for your comment.

ahcorde commented 3 months ago

This is just documentation, merging!

ahcorde commented 3 months ago

https://github.com/Mergifyio backport jazzy iron

mergify[bot] commented 3 months ago

backport jazzy iron

✅ Backports have been created

* [#691 [intra_process_demo] executable name in README.md fix-up (backport #690)](https://github.com/ros2/demos/pull/691) has been created for branch `jazzy` * [#692 [intra_process_demo] executable name in README.md fix-up (backport #690)](https://github.com/ros2/demos/pull/692) has been created for branch `iron`