Open Crola1702 opened 3 months ago
I did take a look at this flaky test issue with connextdds.
1st, this cannot be reproducible with my local dev environment...
2nd, 30 seconds should be long enough to receive the parameter events,
both cases https://ci.ros2.org/view/nightly/job/nightly_linux_debug/3064/testReport/junit/(root)/projectroot/test_tutorial_parameter_events_async__rmw_connextdds/ and https://ci.ros2.org/view/nightly/job/nightly_win_rep/3362/testReport/junit/(root)/projectroot/test_tutorial_parameter_events__rmw_connextdds/ missed the last 2 events below.
3rd, QoS for parameter events is reliable enough, https://github.com/ros2/rmw/blob/22f59f8931944999864ef3b0d7aa75ab7258f028/rmw/include/rmw/qos_profiles.h#L77-L88
after all, i could not find why last 2 events are missing here only connextdds, probably connextdds misses those messages already.
Bug report
Required Info:
Steps to reproduce issue
Description
There is a parent test regression with different variations on ConnextDDS:
demo_nodes_cpp.TestExecutablesTutorial.test_processes_output
Failing test regressions:
Log output (test_tutorial_parameter_events_async__rmw_connextdds):
``` FAIL: test_processes_output (demo_nodes_cpp.TestExecutablesTutorial.test_processes_output) Test all processes output against expectations. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins-agent/workspace/nightly_linux_debug/ws/build/demo_nodes_cpp/test_parameter_events_async__rmw_connextdds_Debug.py", line 74, in test_processes_output proc_output.assertWaitFor( File "/home/jenkins-agent/workspace/nightly_linux_debug/ws/install/launch_testing/lib/python3.12/site-packages/launch_testing/io_handler.py", line 146, in assertWaitFor assert success, 'Waiting for output timed out' ^^^^^^^ AssertionError: Waiting for output timed out ```Log output (test_tutorial_parameter_events__rmw_connextdds):
``` FAIL: test_processes_output (demo_nodes_cpp.TestExecutablesTutorial) Test all processes output against expectations. ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\ci\ws\build\demo_nodes_cpp\test_parameter_events__rmw_connextdds_Release.py", line 74, in test_processes_output proc_output.assertWaitFor( File "C:\ci\ws\install\Lib\site-packages\launch_testing\io_handler.py", line 146, in assertWaitFor assert success, 'Waiting for output timed out' AssertionError: Waiting for output timed out ```Flakiness report (projectroot.test_tutorial_parameter_events_async__rmw_connextdds):
Flakiness report (projectroot.test_tutorial_parameter_events__rmw_connextdds):
I don't see any specific change that points to a reason why it started failing more in normal jobs, and not only repeated ones (package history).
projectroot.test_tutorial_parameter_events_async__rmw_connextdds
projectroot.test_tutorial_parameter_events__rmw_connextdds: