ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
222 stars 194 forks source link

lifecycle: change noun to verb for 'deactivate' #154

Closed gavanderhoorn closed 6 years ago

gavanderhoorn commented 6 years ago

As per subject.

Reading the rest of the article I'm pretty sure the transition is actually named deactivate, not deactive (which could be a state name).

Karsten1987 commented 6 years ago

thanks for the patch. The transition is indeed called deactivate and the corresponding state inactive

https://github.com/ros2/rcl_interfaces/blob/master/lifecycle_msgs/msg/Transition.msg#L12 https://github.com/ros2/rcl_interfaces/blob/master/lifecycle_msgs/msg/State.msg#L10