search

ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
222 stars 194 forks source link

Fix a typo. #158

Closed csukuangfj closed 6 years ago

dirk-thomas commented 6 years ago

"build types" are imo not "implemented". I think saying that a build type like cmake is "supported" is more precise. Therefore I would suggest:

which allows to support other build types without changing the ament tool itself.

dirk-thomas commented 6 years ago

"build types" are imo not "implemented". I think saying that a build type like cmake is "supported" is more precise. Therefore I would suggest:

which allows to support other build types without changing the ament tool itself.

@sloretz @mikaelarguedas Do you have any comment on this?

dhood commented 6 years ago

I agree with you @dirk-thomas . Would just change the english to "Support for different build systems is integrated through extension points which allows support for other build types to be added without changing the ament tool itself."

mikaelarguedas commented 6 years ago

mikaelarguedas Do you have any comment on this?

The current state of this PR seems fine to me: "Support for different build systems is integrated through extension points which allows to contribute support for other build types without changing the ament tool itself."

@dhood'd suggestion is fine as well it just changes "which allows to contribute support for other build types" to "which allows support for other build types to be added".

I dont think it deserves to be changed but maybe it's more english.

sloretz commented 6 years ago

I'm happy with either "supported" or "implemented".

dirk-thomas commented 6 years ago

I updated it to:

... which allows support for other build types to be added without changing the ament tool itself.

I will leave it up to someone else to squash and merge this. :+1: from me.

dirk-thomas commented 6 years ago

@csukuangfj Thank you for your attention to detail.