ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
218 stars 193 forks source link

Remapping Names isn't apply to node name on ros2 bouncy #205

Closed Guochd closed 5 years ago

Guochd commented 5 years ago

Remapping Names is apply to node name on ros1 example:

       rosrun turtlesim turtlesim_node __name:=A __ns:=/pp
       rostopic list 
                    /pp/turtle1/cmd_vel
                    /pp/turtle1/color_sensor
                    /pp/turtle1/pose
        rosnode list 
                     /pp/A

Remapping Names isn't apply to node name on ros2 bouncy example :+1:

         ros2 run demo_nodes_cpp talker __ns:=/tt __node:=JJ
         ros2 run topic list 
                  /tt/chatter
         ros2 run topic list 
                  JJ

My question is why not the action is not same between ros1 and ROS2 bouncy。

sloretz commented 5 years ago

Hi @Guochd,

Are you asking why the output of ros2 node list is JJ instead of /tt/JJ? It looks like a bug that was fixed after bouncy was released.

With this node in the background

ros2 run demo_nodes_cpp talker __ns:=/tt __node:=JJ

Using bouncy I see the following

$ ros2 node list
JJ

Using a pre-release of crystal I see

$ ros2 node list
/tt/JJ

If you would like to see it released in bouncy, I recommend opening a PR at https://github.com/ros2/ros2cli targeted at the branch bouncy with a fix.

I will close this for now. It can be reopened if this does not answer your question.