search

ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
218 stars 193 forks source link

Propose ROS 2 launch front-end design hints. #208

Closed hidmic closed 5 years ago

hidmic commented 5 years ago

This is a proposal on how to go about implementing something like #207 in an extensible way. Approaches described in here are a combination of ideas I had and ideas that @wjwwood had and shared with me, thus the dual authorship.

I hope that by the time this gets merged we either have chosen one of these approaches or came up with a another one to actually implement.

hidmic commented 5 years ago

Also, a big thing that is missing (but possibly orthogonal to these approaches) is substitutions and how they would be handled.

And I think that's exactly why I skipped them in the first place. The document now covers a bit on how substitutions could be handled. PTAL! And thanks for reviewing it in the first place!

ivanpauno commented 5 years ago

@hidmic I addressed the comments, and updated it to match better with the actual implementation (it was actually matching pretty well).

ivanpauno commented 5 years ago

I think this PR is ready. We will deal with event_handlers in the next iteration, but I didn't delete reference to them as this is a design hints document.