ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
223 stars 194 forks source link

Add design document for ROS 2 Access Control Policies #246

Closed ruffsl closed 5 years ago

ruffsl commented 5 years ago

As currently used for SROS 2.

ruffsl commented 5 years ago

If there is no more feedback, perhaps we could merge on this, that reflects the current state, so that we can open a new PR to extend the design to account for proposals on composing nodes and contexts. e.g: https://github.com/ros2/design/pull/250#issuecomment-525034819

@kyrofa @tfoote

ruffsl commented 5 years ago

@jacobperron , thanks for the wording suggestions. They all looked fine to me.

jacobperron commented 5 years ago

The change to the CSS is unrelated to the SROS article and I think would be best to pull out into a separate PR to review.

ruffsl commented 5 years ago

I think would be best to pull out into a separate PR to review.

I've rebased the PR and opened the syntax highlighting changes to its own PR: https://github.com/ros2/design/pull/253

jacobperron commented 5 years ago

Thanks for splitting out the PR. LGTM