search

ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
215 stars 194 forks source link

Update 116_legacy_interface_definition.md #308

Closed dawonn closed 3 years ago

dawonn commented 3 years ago

Support constants defined in binary, octal, decimal, & hex.

Implementation: https://github.com/ros2/rosidl/pull/559

clalancette commented 3 years ago

@dawonn Friendly ping on this one, would you mind making the updates from https://github.com/ros2/design/pull/308#discussion_r551542264 and https://github.com/ros2/design/pull/308#discussion_r551577699 ?

dawonn commented 3 years ago

Thanks for the ping, I believe I made the requested changes.

Please feel free to push a change to my branch if you like or give me a serving of copy-pasta.

clalancette commented 3 years ago

I went ahead and expanded it more. I now think this is good, so I'm going to approve. However, since I made changes here I'd appreciate review from @sloretz .

clalancette commented 3 years ago

@gbiggs Thanks for the review. I'm going to go ahead and merge this, and then go review the corresponding code change.