search

ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
215 stars 194 forks source link

Fix launch_xml examples #312

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

Remove 'sep' attribute and use square brackets for lists.

As far as I know, this is the correct sytax for a list value and the 'sep' attribute was never implemented.

@hidmic @ivanpauno Does this look correct?

ivanpauno commented 3 years ago

As far as I know, this is the correct sytax for a list value and the 'sep' attribute was never implemented.

IIRC, you have to use value="Some phrase,'100.0','true'" value-sep=","

jacobperron commented 3 years ago

IIRC, you have to use value="Some phrase,'100.0','true'" value-sep=","

Interesting. I found some docs about it here.

I've updated this PR with the correct syntax, and also added an example that doesn't use the *-sep attribute.