search

ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
223 stars 194 forks source link

Update Launch XML Schema #317

Closed rob-clarke closed 3 years ago

rob-clarke commented 3 years ago

Similar to #285 I believe the schema doesn't match the current implementation.

In the schema, the <node> element currently defines a ns attribute but this appears to have been renamed to namespace. At least if here is where it is being parsed.

@ivanpauno Mentioning you as it's similar to the other issue you dealt with.

ivanpauno commented 3 years ago

@rob-clarke you're correct, the correct attribute is namespace and not ns. A PR is welcomed.

defines a ns attribute but this appears to have been renamed to namespace

The attribut has always been namespace, but it was wrongly documented as ns in the schema.

christophebedard commented 3 years ago

I can take care of this (if @rob-clarke isn't already on it) and also add ros_args (https://github.com/ros2/launch_ros/pull/253) at the same time

christophebedard commented 3 years ago

I can take care of this (if @rob-clarke isn't already on it) and also add ros_args (ros2/launch_ros#253) at the same time

I just went ahead and did it: #318