search

ros2 / design

Design documentation for ROS 2.0 effort
http://design.ros2.org/
Apache License 2.0
215 stars 194 forks source link

ROS2 DDS Security PKCS#11 URI support #332

Closed MiguelCompany closed 1 year ago

MiguelCompany commented 1 year ago

This is a rework of #319, addressing the comments there, since I don't have write access on the original contributor repository.

kallekoivisto commented 1 year ago

This is good

maseabunikie commented 1 year ago

:+1:

MiguelCompany commented 1 year ago

@mikaelarguedas Thanks for the review. Just applied your fixes.

ruffsl commented 1 year ago

Ping @clalancette or @tfoote ? Good to merge?

tfoote commented 1 year ago

In general this sounds good. However this site overall is deprecated and we would much prefer to land this as a REP instead so that we can have all of our reference materials in one place. Would you mind submitting it over there as a new informational REP instead?

ros-discourse commented 1 year ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-02-16/29927/1

EduPonz commented 1 year ago

Hi @tfoote, we have gone ahead and moved this to a REP in ros-infrastructure/rep#375

MiguelCompany commented 1 year ago

Closing in favor of https://github.com/ros-infrastructure/rep/pull/375

ros-discourse commented 1 year ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/announcing-rep-2015-ros-2-dds-security-pkcs-11-support/31357/1