Open wjwwood opened 7 years ago
In design article it say :
must not have an underscore () followed by a forward slash (/), i.e. /
but in valid example :
foo/_/bar
Can you clarify ?
ind design acticle it say :
must not contain any number of repeated underscores (_)
but in current implementation of Parameter service :
node_->get_name() + "__get_parameters",
https://github.com/ros2/rclcpp/blob/5894a9cd4eb0371e380dcbac73b74efae353fde2/rclcpp/src/rclcpp/parameter_service.cpp
It is excluded of Service name of parameter stack ?
@Theosakamg looks like I missed that one (foo/_/bar
) when updating the rules. Thanks for pointing it out! I'll open a pr to fix it.
As for the current implementation, it doesn't follow this design doc yet (the implementation is lagging behind the document). We'll replace that line with something like this:
node_->get_name() + "/_get_parameters",
Or something similar, so that it uses the /
namespace separator and is "hidden".
If you have further comments, please open a new issue or comment on the original pr (https://github.com/ros2/design/pull/90). This issue is specifically about completing the EBNF (candidate implementation is in #96).
See: https://github.com/ros2/design/pull/90#issuecomment-247329344