Add explicit link against stdc++fs

ros2 / domain_bridge

Bridge communication across different ROS 2 domains.

Apache License 2.0

55 stars 11 forks source link

Add explicit link against stdc++fs #16

Closed cottsay closed 3 years ago

cottsay commented 3 years ago

It seems that this may not be necessary with GCC 9, but stdc++fs isn't part of libstdc++ prior to that.

Should unblock RHEL builds: https://build.ros2.org/job/Rbin_rhel_el864__domain_bridge__rhel_8_x86_64__binary/4/console

Is there any CI I should trigger for this change?

jacobperron commented 3 years ago

Is there any CI I should trigger for this change?

It's automatically triggered :slightly_smiling_face:

edit: I haven't tested with macOS or Windows to date, so I wouldn't worry about it for this PR.

cottsay commented 3 years ago

There is another fix we'll need regarding the installation of test resources to unblock RHEL builds, so don't do a release just for this fix. I'll try to follow up later today with a PR.