Reintroduce compatibility with galactic

ros2 / domain_bridge

Bridge communication across different ROS 2 domains.

Apache License 2.0

55 stars 11 forks source link

Closed ivanpauno closed 3 years ago

ivanpauno commented 3 years ago

https://github.com/ros2/domain_bridge/pull/27 broke compatibility with galactic. This patch should reintroduce it :crossed_fingers: .

Overriding both handle_message() and handle_serialized_message() shouldn't be a problem.

ivanpauno commented 3 years ago

Okay, the failing test is probably just a flaky one. Seems to be the same issue as https://github.com/ros2/domain_bridge/pull/25#issuecomment-858723578. I will see if I can refactor those tests and fix them.

jacobperron commented 3 years ago

I guess we can close this since #30 has been merged.

ivanpauno commented 3 years ago

I guess we can close this since #30 has been merged.

Yes, superseded by #30.