search

ros2 / domain_bridge

Bridge communication across different ROS 2 domains.
Apache License 2.0
52 stars 12 forks source link

Run communication-related tests with all available RMWs #43

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

Follow-up to https://github.com/ros2/domain_bridge/issues/41. Hopefully this will prevent regressions for RMWs that are not the ROS 2 default.

jacobperron commented 3 years ago

For reference, here is the documentation for call_for_each_rmw_implementation.

jacobperron commented 3 years ago

The service tests should fail for rmw_fastrtps_cpp and rmw_connextdds (until #42 is merged). However, the Rpr job only installs the default RMW (rmw_cyclonedds_cpp) so we don't see any failures. The GitHub workflow fails since the action-ros-ci installs rmw_fastrtps_cpp (in addition to cyclonedds). action-ros-ci also has an option for installing Connext, which we could enable.

I'm not sure if there's a recommended practice for forcing multiple RMWs to be installed for the buildfarm jobs; I'll ask around.

jacobperron commented 3 years ago

I've added explicit test dependencies on tier 1 RMWs to ensure we're testing against them (427676e).

jacobperron commented 3 years ago

Rebased now that https://github.com/ros2/domain_bridge/pull/42 is merged. I expect all tests to pass now :crossed_fingers:

jacobperron commented 3 years ago

This isn't necessary since the Rolling job should catch Connext failures now, but we could do it anyway just to be cautious.

I think we can disable the GitHub action CI considering we've got the same coverage on build.ros2.org.

jacobperron commented 3 years ago

I think we can disable the GitHub action CI considering we've got the same coverage on build.ros2.org.

On second thought, I'll just leave it for now since it's not broken and it might be useful for running macOS and Windows CI in the future.

ivanpauno commented 3 years ago

On second thought, I'll just leave it for now since it's not broken and it might be useful for running macOS and Windows CI in the future.

That's a good point!