ros2 / domain_bridge

Bridge communication across different ROS 2 domains.
Apache License 2.0
52 stars 12 forks source link

Use unambiguous call to shared_from_this() #48

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

This fixes a compilation error when building against the latest version of rclcpp:

 error: request for member 'shared_from_this' is ambiguous
  116 |     callback_(this->shared_from_this(), request_header, typed_request);
      |               ~~~~~~^~~~~~~~~~~~~~~~
jacobperron commented 3 years ago

@ros-pull-request-builder retest this please

jacobperron commented 3 years ago

@ros-pull-request-builder retest this please

ivanpauno commented 3 years ago

It seems that this patch didn't work, I will take a look locally

jacobperron commented 3 years ago

Replaced by #49