Closed ivanpauno closed 3 years ago
I think the test failures are known flakes and I guess the workflow is failing because it not using the testing repo for Rolling debs. I would go ahead and merge this.
See https://github.com/ros2/domain_bridge/pull/50 for switching CI to use the testing repo.
LGTM. The main branch is currently targeting Rolling. We have a separate galactic branch now.
Sounds good! I forgot about that
I've rebased this after merging #50.
Replaces https://github.com/ros2/domain_bridge/pull/48.
Multiple inheritance with
std::enable_shared_from_this
is problematic, see:The solutions proposed in those threads cannot directly applied here.
To avoid the issue, I'm using the support for defering responses in services added in rclcpp, avoiding the need of using
std::enable_shared_from_this
all together. We will need a new branch for rolling though, but I couldn't find a backwards compatible solution.