search

ros2 / domain_bridge

Bridge communication across different ROS 2 domains.
Apache License 2.0
52 stars 12 forks source link

Make some end to end tests more reliable #51

Closed ivanpauno closed 3 years ago

ivanpauno commented 3 years ago

Fixes https://github.com/ros2/domain_bridge/issues/46.

ivanpauno commented 3 years ago

I tried this patch locally, and it seem that it can sometimes still fail. I think the issue is that maybe the internal pub/sub that the domain_bridge has created haven't matched the external sub/pub yet.

We can merge this and check if it avoids the issue in CI, if not we will have to add some retrying logic. We could also use publishers with TRANSIENT_LOCAL durability in the tests, in that case this shouldn't be a problem.

rebecca-butler commented 3 years ago

We could also use publishers with TRANSIENT_LOCAL durability in the tests, in that case this shouldn't be a problem.

It seems like we still have the CI issue with the current patch, so I would support this solution.

jacobperron commented 3 years ago

+1 for using transient_local durability in the tests.

ivanpauno commented 3 years ago

Done, I tested locally and it seems to be working pretty reliably now.

jacobperron commented 3 years ago

Looks like we're still getting unlucky with a test failing :slightly_frowning_face: