Add option to wait for subscription before bridging a topic

ros2 / domain_bridge

Bridge communication across different ROS 2 domains.

Apache License 2.0

52 stars 12 forks source link

Add option to wait for subscription before bridging a topic #52

Closed ivanpauno closed 2 years ago

ivanpauno commented 3 years ago

Maybe we could first wait for a subscription, and when that's ready register a callback to wait for the publisher qos (?). Currently I'm not doing that, and QOS settings must by provided through a yaml file (or they will be a default reliable profile).

I have done some manual testing, but after a first review I'm planning to add some automated tests.

ivanpauno commented 3 years ago

@ivanpauno What do you think?

sounds good to me

ivanpauno commented 2 years ago

It would be good to add some tests for the new options before merging.

Test added in https://github.com/ros2/domain_bridge/pull/52/commits/d2e2273169c8ba697d6ebe7697bf4426dc2c1b3d,