search

ros2 / domain_bridge

Bridge communication across different ROS 2 domains.
Apache License 2.0
52 stars 12 forks source link

Auto remove bridge when endpoint removed #63

Closed ivanpauno closed 2 years ago

ivanpauno commented 2 years ago

The callbacks added to the WaitForGraphEvents object are now kept forever instead of being removed after the first time they are called. There might be another way to get this working (register callback waiting for publishing/subscription, remove it and register the one waiting for publisher/subscription/removed, ...), though I find that more complex to implement in the current code.

ivanpauno commented 2 years ago

We should add some tests to exercise the new functionality.

See https://github.com/ros2/domain_bridge/pull/63/commits/7742dec8d417808d0531d6eabf112b9478222a99