Fixes for Ubuntu Jammy - Githubissues

ros2 / domain_bridge

Bridge communication across different ROS 2 domains.

Apache License 2.0

52 stars 12 forks source link

Fixes for Ubuntu Jammy #66

Closed jacobperron closed 2 years ago

jacobperron commented 2 years ago

Fix -Wvesing-parse compiler warning (1d5dbc8bdd348f8d23cf35aca8fb99f319a52a11) Use braces to initialize variable instead of parentheses.
Uncrustify (578137bbe7958a2efc08c95fe7624426fa9fc56b)

christophebedard commented 2 years ago

Bumping ros-tooling/setup-ros to v0.3 should fix the Jammy-related error(s).

jacobperron commented 2 years ago

@christophebedard Thanks, trying it out now.

jacobperron commented 2 years ago

Looks like the setup-ros action is trying to install rti-connext-dds-5.3.1, which is not available for Rolling/Humble. Instead we should be installing rti-connext-dds-6.0.1.

jacobperron commented 2 years ago

I don't think we need to block this PR on the GitHub Action CI. I think the Hpr and Rpr jobs are sufficient.

christophebedard commented 2 years ago

Looks like the setup-ros action is trying to install rti-connext-dds-5.3.1, which is not available for Rolling/Humble. Instead we should be installing rti-connext-dds-6.0.1.

We somehow missed this and apparently don't have a test for it! I'll fix it. You could also remove install-connext: true.

jacobperron commented 2 years ago

We have extra (optional) features in this package that depend explicitly on Connext, so it's nice to have it installed for testing if possible.