search

ros2 / examples

Example packages for ROS 2
Apache License 2.0
691 stars 311 forks source link

using asyncio with ros2 action client #301

Closed alemme closed 3 years ago

alemme commented 3 years ago

I was looking for such an example. Maybe others will find this also useful if they are working with eventloops.

clalancette commented 3 years ago

First, sorry for the delay in looking at this.

Our development process always targets the 'master' branch first, and then we backport to stable distributions if warranted. So I retargeted the branch to master here, and rebased the code on top of that. I also ended up doing a small bit of work to fix the style so it conforms to the style tests. This should now pass CI.

I'm going to do one review pass, looking for any additional issues. Once that is fixed up, I'm happy to run CI and merge this. Thanks for the contribution.

clalancette commented 3 years ago

CI:

clalancette commented 3 years ago

@alemme Oh, you have to go back and sign your commits to pass the DCO bot. Once that is done (and CI comes back clean), I can merge this.

alemme commented 3 years ago

Thanks for the review. Commits should be in order now :)

clalancette commented 3 years ago

And CI looks happy. Thanks for the contribution, merging.