ros2 / examples

Example packages for ROS 2
Apache License 2.0
691 stars 311 forks source link

Add wait set examples #315

Closed carlossvg closed 3 years ago

carlossvg commented 3 years ago

This PR adds examples for how to use the new rclcpp::WaitSet classes. It is an extension of the existing PR https://github.com/ros2/examples/pull/262 created by @wjwwood.

This PR includes the following additional examples:

Some of the examples may be moved to ros2/tutorials or ros2/demos.

Connects to ros2/rclcpp#1047

carlossvg commented 3 years ago

@wjwwood I will add more comments, add a readme and probably rename the examples. Could briefly you take a look and see if you miss an example or a specific usage we want to show?

carlossvg commented 3 years ago

@wjwwood This PR should be ready to review.

wjwwood commented 3 years ago

@Mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: success

Branch has been successfully rebased

carlossvg commented 3 years ago

@wjwwood I addressed your comments. You can review it again.

wjwwood commented 3 years ago

CI:

carlossvg commented 3 years ago

@wjwwood I added your suggestion. Let me know when I should clean the commit history.

wjwwood commented 3 years ago

We squash on merge so you don't need to clean up commit history unless you really want to. If so, do it now.

carlossvg commented 3 years ago

It's fine for me, we can squash as it is. Thanks for the review.

wjwwood commented 3 years ago

The test failures for Windows are on nightly too. I think it was just resolved with https://github.com/ros2/rclcpp/pull/1726, so I'll rerun CI:

wjwwood commented 3 years ago

@carlossvg there are some Windows specific compiler warnings which we'll have to resolve before merging, but otherwise lgtm.

wjwwood commented 3 years ago

CI:

wjwwood commented 3 years ago

I fixed some of the warning, but didn't follow up yet on the rest. I can do that hopefully tonight and get this merged.

wjwwood commented 3 years ago

CI: