Open bhomaidan1990 opened 2 years ago
I can't reproduce the test results. What version of Python and flake8 is installed in your computer? For reference, I have 3.8.10 and 3.7.9 respectively.
@aprotyas Python 3.8.10
flake8 3.9.2
More importantly, what's your version of flake8-blind-except
?
In all likelihood, you are using a version newer than 0.1.1, which we know causes problems. Because of that, in our CI we specifically pin to an earlier version: https://github.com/ros2/ci/blob/eb8d0ad3e9b74a71561c178bb5d8487f77206d35/ros2_batch_job/__main__.py#L55
We would love to move to a newer version of that plugin, but the honest truth is that there are some places where we want to use a blind Exception. One thing we could consider doing is to mark those lines with NOLINT
or whatever the flake8 equivalent is, and then unpin flake8-blind-except
. @bhomaidan1990 If you are willing to do some of that, we'd be happy to review it.
More importantly, what's your version of
flake8-blind-except
?
0.2.0
, I tried to install 0.1.1
instead, but it caused me more issues:
7 packages failed: examples_rclpy_executors examples_rclpy_minimal_action_client examples_rclpy_minimal_action_server examples_rclpy_minimal_client examples_rclpy_minimal_publisher examples_rclpy_minimal_service examples_rclpy_minimal_subscriber
9 packages had stderr output: examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_client examples_rclcpp_minimal_composition examples_rclcpp_minimal_publisher examples_rclcpp_minimal_service examples_rclcpp_minimal_subscriber examples_rclcpp_minimal_timer examples_rclcpp_multithreaded_executor
9 packages had test failures: examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_client examples_rclcpp_minimal_composition examples_rclcpp_minimal_publisher examples_rclcpp_minimal_service examples_rclcpp_minimal_subscriber examples_rclcpp_minimal_timer examples_rclcpp_multithreaded_executor
So I rolled back to 0.2.0
.
0.2.0
, I tried to install0.1.1
instead, but it caused me more issues:
That's...odd, because that is what we use in CI. I'm not sure what is going on there, but I'm certain that 0.1.1 works.
Hi, following ros2-foxy tutorial I have a failure in the
colcon test
.Bug report
Required Info:
examples_rclpy_minimal_client
Steps to reproduce issue
Additional information
cat log/latest_test/examples_rclpy_minimal_client/stdout_stderr.log
Output: