Final batch of examples

ros2 / examples

Example packages for ROS 2

Apache License 2.0

691 stars 311 forks source link

Final batch of examples #327

Closed adityapande-1995 closed 2 years ago

adityapande-1995 commented 2 years ago

Moved from https://github.com/ros2/launch_ros/pull/269 Signed-off-by: Aditya Pande aditya050995@gmail.com

adityapande-1995 commented 2 years ago

@ivanpauno if I make number_of_nodes as a launch argument, I won't be able to use it in generate_launch_description() to launch nodes based on that number

adityapande-1995 commented 2 years ago

TODO :

Split this example into rosbag2 and wait_for_node action :heavy_check_mark:
For rosbag2, make sure the bag file is written consistently in a temp directory :heavy_check_mark:
For wait_for_node action : Write a complete class like we did for WaitForTopics complete with docstrings, so that we can move it to launch_testing_ros later. (Add a TODO in the comment) :heavy_check_mark:
Remove duplicate examples from original repos once we're done with "moving" examples

ivanpauno commented 2 years ago

@ivanpauno if I make number_of_nodes as a launch argument, I won't be able to use it in generate_launch_description() to launch nodes based on that number

You can, it's just a bit tricky. We should have something in launch to make it easier, let me see if I can provide an snippet showing how to do it.

adityapande-1995 commented 2 years ago

CI :

build : --packages-above-and-dependencies launch_testing_examples test : --packages-above launch_testing_examples