search

ros2 / examples

Example packages for ROS 2
Apache License 2.0
691 stars 311 forks source link

Readded WaitForTopics utility #333

Closed adityapande-1995 closed 2 years ago

adityapande-1995 commented 2 years ago

This PR aims to revert the changes made in https://github.com/ros2/examples/pull/326, as the upstream issue with unit tests in rclpy has been fixed https://github.com/ros2/launch_ros/pull/278, and WaitForTopics has been added back to launch_testing_ros https://github.com/ros2/launch_ros/pull/288

Signed-off-by: Aditya aditya050995@gmail.com

clalancette commented 2 years ago

https://github.com/ros/rosdistro/pull/31478 is a new release of launch_ros. It will probably take a couple of hours for that to rebuild, but once that is done we can re-run the Rpr job.

adityapande-1995 commented 2 years ago

@ros-pull-request-builder retest this please

clalancette commented 2 years ago

@ros-pull-request-builder retest this please

adityapande-1995 commented 2 years ago

CI :

Windows CI round 2 : Build Status

adityapande-1995 commented 2 years ago

Running full CI as discussed with @ivanpauno : build : --packages-above-and-dependencies launch_testing_examples rclpy ament_package launch_ros test: --packages-above launch_testing_examples rclpy ament_package launch_ros

Errors in CI seem to be in rclcpp, rosbag2 are unrelated to the changes here. Vanilla rolling CI :

adityapande-1995 commented 2 years ago

I'll disable set_param_launch_test for now, as it is failing on windows. Originally added here with green CI : https://github.com/ros2/examples/pull/324

adityapande-1995 commented 2 years ago

Windows CI : Build Status Vanilla Windows CI : Build Status

The only error (test_record_) not common in these 2 seems to be unrelated to the changes made here.