search

ros2 / examples

Example packages for ROS 2
Apache License 2.0
681 stars 308 forks source link

increase the timeout for window platform to avoid flaky test #355

Closed iuhilnehc-ynos closed 1 year ago

iuhilnehc-ynos commented 1 year ago

A flaky test about launch_testing_examples\check_multiple_nodes_launch_test.py is always reported while running CI.

After comparing the success and failure cases between https://ci.ros2.org/job/ci_windows/18721/consoleFull and https://ci.ros2.org/job/ci_windows/18738/consoleFull, I suspect that the timeout of waiting on the Window platform might not be enough.

Successful log in https://ci.ros2.org/job/ci_windows/18721/consoleFull,

01:22:55 launch_testing_examples\check_multiple_nodes_launch_test.py RR.          [ 22%]

Failure log in https://ci.ros2.org/job/ci_windows/18738/consoleFull.

23:58:21 launch_testing_examples\check_multiple_nodes_launch_test.py RRF          [ 22%]

We can find two re-test actions even in the successful log. (RR.)

iuhilnehc-ynos commented 1 year ago

First time to run CI on Window. (1/10)

iuhilnehc-ynos commented 1 year ago

ran CI with wrong value --package-select for CI_TEST_ARGS before, which should be --packages-select. rerun CI (2/10),

rerun CI (3/10),

rerun CI (4/10),

rerun CI (5/10),

rerun CI (6/10),

In order to not occupy the CI resource, I'll rerun a full CI later.

iuhilnehc-ynos commented 1 year ago

CI:

clalancette commented 1 year ago

I'm going to go ahead and merge this one, since it is low-risk and seems to be helping. We can always do another follow-up if this isn't enough.