Add guard on Python single goal action server example

ros2 / examples

Example packages for ROS 2

Apache License 2.0

703 stars 312 forks source link

Add guard on Python single goal action server example #380

Closed mrjogo closed 4 months ago

mrjogo commented 4 months ago

Fixes https://github.com/ros2/examples/issues/371

fujitatomoya commented 4 months ago

@mrjogo can you fix DCO error? i think you just missed --signoff for the 2nd commit.

mrjogo commented 4 months ago

@mrjogo can you fix DCO error? i think you just missed --signoff for the 2nd commit.

Sorry, gets me every time. Done.

ahcorde commented 4 months ago

Linux
Linux-aarch64
Windows

ahcorde commented 4 months ago

https://github.com/Mergifyio backport jazzy

mergify[bot] commented 4 months ago

backport jazzy

✅ Backports have been created

* [#381 Add guard on Python single goal action server example (backport #380)](https://github.com/ros2/examples/pull/381) has been created for branch `jazzy`

ahcorde commented 4 months ago

@fujitatomoya Do we need to backport this to iron or humble?

fujitatomoya commented 4 months ago

@ahcorde would be nice. even though this is an example code, users likely copy&paste the examples, i think.

ahcorde commented 4 months ago

https://github.com/Mergifyio backport humble iron

mergify[bot] commented 4 months ago

backport humble iron

✅ Backports have been created

* [#383 Add guard on Python single goal action server example (backport #380)](https://github.com/ros2/examples/pull/383) has been created for branch `humble` * [#384 Add guard on Python single goal action server example (backport #380)](https://github.com/ros2/examples/pull/384) has been created for branch `iron`