search

ros2 / geometry2

A set of ROS packages for keeping track of coordinate transforms.
BSD 3-Clause "New" or "Revised" License
118 stars 195 forks source link

Enable StaticTransformBroadcaster in Intra-process enabled components #607

Closed roncapat closed 1 year ago

roncapat commented 1 year ago

Follow up of this comment made by @FranzAlbers (and PR #572 in general).

FYI @nachovizzo(https://github.com/PRBonn/kiss-icp/pull/171) and @fixit-davide.

roncapat commented 1 year ago

I also added a small test as I did for the TransformListener :)

roncapat commented 1 year ago

@clalancette wait wait, I missed some fixes to the comments sorry!

EDIT: done, just need to see if uncrustify is happy with different newlines in the comment blocks. Sorry again for that :)

clalancette commented 1 year ago

CI:

roncapat commented 1 year ago

Thanks a lot! Can we backport to iron and humble?

ahcorde commented 1 year ago

https://github.com/Mergifyio backport iron humble

mergify[bot] commented 1 year ago

backport iron humble

✅ Backports have been created

* [#611 Enable StaticTransformBroadcaster in Intra-process enabled components (backport #607)](https://github.com/ros2/geometry2/pull/611) has been created for branch `iron` * [#612 Enable StaticTransformBroadcaster in Intra-process enabled components (backport #607)](https://github.com/ros2/geometry2/pull/612) has been created for branch `humble` but encountered conflicts