ros2 / geometry2

A set of ROS packages for keeping track of coordinate transforms.
BSD 3-Clause "New" or "Revised" License
118 stars 195 forks source link

Add time jump callback #608

Closed erichlf closed 1 year ago

erichlf commented 1 year ago

When use_sim_time is set the python tf2 buffer should be cleared. However, this wasn't happening. To handle this a time jump callback was added to clear the buffer when a time jump is detected.

erichlf commented 1 year ago

This build errors make no sense to me

E     File "/tmp/ws/src/geometry2/tf2_ros_py/tf2_ros/buffer.py", line 98
E       post_callback=time_jump_callback
E       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   SyntaxError: invalid syntax. Maybe you meant '==' or ':=' instead of '='
erichlf commented 1 year ago

These failing tests are baffling. This is definitely valid syntax.

clalancette commented 1 year ago

@ros-pull-request-builder retest this please

clalancette commented 1 year ago

CI:

dhood commented 10 months ago

thank you @erichlf , I am looking forward to using this! :raised_hands: