ros2 / geometry2

A set of ROS packages for keeping track of coordinate transforms.
BSD 3-Clause "New" or "Revised" License
113 stars 193 forks source link

which callback group should be default callback group in transform_listener.py #609

Closed sorawit112 closed 12 months ago

sorawit112 commented 1 year ago

In branch humble transform_listener.py have this following lines of code

-- # Default callback group is mutually exclusive, which would prevent waiting for transforms -- # from another callback in the same group. -- self.group = ReentrantCallbackGroup()

the comment said default callback group is Mutually Exclusive but the real one is Reentrant so which one is correct?

cmraaron commented 12 months ago

I believe this comment is saying that the default callback group would be mutually exclusive, if it were not explicitly set. And therefore explicitly sets it to a ReentrantCallbackGroup

clalancette commented 12 months ago

I believe this comment is saying that the default callback group would be mutually exclusive, if it were not explicitly set. And therefore explicitly sets it to a ReentrantCallbackGroup

Yes, that's correct.

Given that this is a question, I'm going to close this out. In the future please open questions like this on https://answers.ros.org.